Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCSFuse cache enabled a3-mega blueprint #3460

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

koallison
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@tpdownes tpdownes self-assigned this Jan 10, 2025
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor suggestions

dir-mode: "777"
file-mode: "777"
rename-dir-limit: 0 # Set to 20000 for hierarchical buckets
temp-dir: /mnt/localssd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use

Suggested change
temp-dir: /mnt/localssd
temp-dir: $(vars.localssd_mountpoint)

max-size-mb: -1
metadata-cache:
ttl-secs: 3600
cache-dir: /mnt/localssd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cache-dir: /mnt/localssd
cache-dir: $(vars.localssd_mountpoint)

dir-mode: "555" # need 5 on dir to enable ls
file-mode: "444"
rename-dir-limit: 0 # Set to 20000 for hierarchical buckets
temp-dir: /mnt/localssd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
temp-dir: /mnt/localssd
temp-dir: $(vars.localssd_mountpoint)

@tpdownes tpdownes assigned koallison and unassigned tpdownes Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants